Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Full ART types extracted from DefinitelyTyped #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

steadicat
Copy link

Summary

The type definitions in this repo are woefully incomplete. Thankfully, DefinitelyTyped types for RN have full types for ART. This copies over the relevant types from https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-native/index.d.ts.

Fixes #59.

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@nschild
Copy link

nschild commented Oct 20, 2020

@steadicat Looks like it is still missing quite a few typings. Notably rotation on Group, strokeJoin on Shape, but I am sure there are more.


export class Surface extends React.Component<ARTSurfaceProps> {}
//////////////////////////////////////////////////////////////////////////
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this ugly comment? I don't think we need this in declarations.

@vladkosinov
Copy link

@steadicat ping

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript Path not in index.d.ts
4 participants